xend: modify a warning log message
authorKeir Fraser <keir.fraser@citrix.com>
Wed, 1 Apr 2009 10:47:59 +0000 (11:47 +0100)
committerKeir Fraser <keir.fraser@citrix.com>
Wed, 1 Apr 2009 10:47:59 +0000 (11:47 +0100)
Signed-off-by: Kouya Shimura <kouya@jp.fujitsu.com>
tools/python/xen/xend/image.py

index c058cecb9ee7b3b73886ed8c4ee5a38582176718..1f2eb4a9f5c1c84da2e0edccf7d3521d2ee14998 100644 (file)
@@ -534,8 +534,8 @@ class ImageHandler:
         try: self.sentinel_fifo.read(1)
         except OSError, e: pass
         self.sentinel_lock.acquire()
-        try:
-            if self.pid:
+        if self.pid:
+            try:
                 (p,st) = os.waitpid(self.pid, os.WNOHANG)
                 if p == self.pid:
                     message = oshelp.waitstatus_description(st)
@@ -547,15 +547,15 @@ class ImageHandler:
                     except:
                         message = "malfunctioning or died ?"
                 message = "pid %d: %s" % (self.pid, message)
-            else:
-                message = "no longer running"
-        except Exception, e:
-            message = "waitpid failed: %s" % utils.exception_string(e)
-        message = "device model failure: %s" % message
-        try: message += "; see %s " % self.logfile
-        except: pass
-        self._dmfailed(message)
-        self.pid = None
+            except Exception, e:
+                message = "waitpid failed: %s" % utils.exception_string(e)
+            message = "device model failure: %s" % message
+            try: message += "; see %s " % self.logfile
+            except: pass
+            self._dmfailed(message)
+            self.pid = None
+        else:
+            log.info("%s device model terminated", self.vm.getName())
         self.sentinel_lock.release()
 
     def destroyDeviceModel(self):